Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation to DynamicStorageBuffer to clarify purpose #17228

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add documentation to DynamicStorageBuffer to clarify purpose #17228

merged 2 commits into from
Jan 10, 2025

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Fixes #15052

Solution

Add sentence from @JMS55

@BenjaminBrienen @JMS55
Add doc
63adba3 
Co-authored-by: JMS55 <[email protected]>
@BenjaminBrienen BenjaminBrienen self-assigned this Jan 8, 2025
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Docs An addition or correction to our documentation labels Jan 8, 2025
@BenjaminBrienen
Copy link
Contributor Author

Feel free to suggest a different comment. I'm no expert, just trying to implement it based on what I read in the issue.

@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 10, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 10, 2025
Merged via the queue into bevyengine:main with commit 454dd27 Jan 10, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeedai djeedai djeedai approved these changes

@JMS55 JMS55 Awaiting requested review from JMS55

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The doc for DynamicStorageBuffer doesn't really explain the difference with StorageBuffer
3 participants
@BenjaminBrienen @djeedai @alice-i-cecile